Update Batch create hedge for client #4
Open
claircui wants to merge 8 commits intodevelopmentfrom
Open
Conversation
added 8 commits
August 26, 2022 16:36
Comment on lines
33
to
+38
| batch_size = 400 | ||
|
|
||
| def __init__(self, address: str = "guardian", port: str = "50065"): | ||
| def __init__(self, | ||
| address: str = "guardian", | ||
| port: str = "50065", | ||
| batch_size: int = None): |
Contributor
There was a problem hiding this comment.
Why not put batch_size: int = 400 instead of None? Then you don't need the if statement below
Comment on lines
+46
to
+47
| if batch_size is not None: | ||
| self.batch_size = batch_size |
Contributor
There was a problem hiding this comment.
This is not needed if you set the default to 400 in the init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
push latest to pypi with version # 1.4.2